Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cvaa overlay responsive fixes #81

Merged
merged 2 commits into from
Oct 16, 2017
Merged

fix: cvaa overlay responsive fixes #81

merged 2 commits into from
Oct 16, 2017

Conversation

dvh91
Copy link

@dvh91 dvh91 commented Oct 16, 2017

Description of the Changes

Accessibility issue of apply button in responsive version of advanced cvaa overlay fix.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dvh91 dvh91 self-assigned this Oct 16, 2017
@dvh91 dvh91 requested a review from dan-ziv October 16, 2017 13:36
@OrenMe OrenMe closed this Oct 16, 2017
@OrenMe OrenMe reopened this Oct 16, 2017
@OrenMe OrenMe closed this Oct 16, 2017
@OrenMe OrenMe reopened this Oct 16, 2017
@OrenMe OrenMe merged commit 207e880 into master Oct 16, 2017
@OrenMe OrenMe deleted the cvaa-overlay-responsive-fixes branch October 16, 2017 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@dvh91 dvh91

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dvh91 @OrenMe