Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ADA-95): Purpose of logo link on player is not clear in context #814

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix(ADA-95): Purpose of logo link on player is not clear in context #814

merged 1 commit into from
Nov 21, 2023

Conversation

Tzipi-kaltura
Copy link
Contributor

@Tzipi-kaltura Tzipi-kaltura commented Nov 7, 2023 •
edited by jira bot

Description of the Changes

aria-label was [object object] instead of the strings from the translation object.

solves ADA-95

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Tzipi-kaltura Tzipi-kaltura merged commit fef3444 into master Nov 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lianbenjamin lianbenjamin lianbenjamin approved these changes

@JonathanTGold JonathanTGold Awaiting requested review from JonathanTGold

@SivanA-Kaltura SivanA-Kaltura Awaiting requested review from SivanA-Kaltura

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tzipi-kaltura @lianbenjamin