Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: open clickthrough in new tab/window #82

Merged
merged 1 commit into from
Oct 17, 2017
Merged

fix: open clickthrough in new tab/window #82

merged 1 commit into from
Oct 17, 2017

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Oct 16, 2017 •
edited

Description of the Changes

open clickthrough URL in a separate new tab/window.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe OrenMe self-assigned this Oct 16, 2017
@OrenMe OrenMe requested review from dvh91 and dan-ziv October 16, 2017 23:31
@dan-ziv dan-ziv closed this Oct 17, 2017
@dan-ziv dan-ziv reopened this Oct 17, 2017
@dan-ziv dan-ziv merged commit ef4ce38 into master Oct 17, 2017
@dan-ziv dan-ziv deleted the FEC-7269 branch October 17, 2017 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvh91 dvh91 dvh91 approved these changes

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@OrenMe OrenMe

Labels
Priority: Medium Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OrenMe @dvh91 @dan-ziv