fix(FEC-13632): Define kaltura-player-js types locally instead of import them as a dep(circular deps) #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 9, 2024 12:13
…elationship form the first place)
JonathanTGold
requested review from
MosheMaorKaltura,
semarche-kaltura,
lianbenjamin and
inbalvasserman
JonathanTGold
changed the title
JonathanTGold
changed the title
JonathanTGold
changed the title
JonathanTGold
changed the title
semarche-kaltura
approved these changes
Jan 9, 2024
JonathanTGold
changed the title
JonathanTGold
changed the title
JonathanTGold
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Remove kaltura-player-js dep
Issue: kaltura player github `actions faild since it depend on playkit-ui types which in turn depend on kaltura-player... and so on.. and on and on... Jesus Christ...
Apparently it used by e2e tests...
restored
Fix: dependency should not depend on dependent....
Resolves FEC-FEC-13632
Related Prs:
kaltura/kaltura-player-js#690