Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7152): sorting video tracks by bandwidth bug fix #88

Merged
merged 1 commit into from
Oct 18, 2017
Merged

fix(FEC-7152): sorting video tracks by bandwidth bug fix #88

merged 1 commit into from
Oct 18, 2017

Conversation

dvh91
Copy link

@dvh91 dvh91 commented Oct 18, 2017

Description of the Changes

Sort function return value should be -1 | 0 | 1 instead of boolean for cross platform support.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dvh91 dvh91 self-assigned this Oct 18, 2017
@dvh91 dvh91 requested a review from dan-ziv October 18, 2017 07:25
@dan-ziv dan-ziv merged commit 8560d29 into master Oct 18, 2017
@dan-ziv dan-ziv deleted the video-flavours-sort branch October 18, 2017 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

Assignees

@dvh91 dvh91

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dvh91 @dan-ziv