Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7320): disable accessibility control bars when hidden #92

Merged
merged 1 commit into from
Oct 20, 2017
Merged

fix(FEC-7320): disable accessibility control bars when hidden #92

merged 1 commit into from
Oct 20, 2017

Conversation

dvh91
Copy link

@dvh91 dvh91 commented Oct 20, 2017

Description of the Changes

disable accessibility control bars when hidden

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dvh91 dvh91 self-assigned this Oct 20, 2017
@dvh91 dvh91 requested a review from dan-ziv October 20, 2017 07:00
@dan-ziv dan-ziv merged commit e6f3d67 into master Oct 20, 2017
@dan-ziv dan-ziv deleted the FEC-7320 branch October 20, 2017 10:43
RoyBregman added a commit that referenced this pull request Dec 16, 2019
@RoyBregman
after review #92 with Yair
e7bc170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

Assignees

@dvh91 dvh91

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dvh91 @dan-ziv