Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7312): preact portal fix in Explorer #95

Merged
merged 2 commits into from
Oct 23, 2017
Merged

fix(FEC-7312): preact portal fix in Explorer #95

merged 2 commits into from
Oct 23, 2017

Conversation

dvh91
Copy link

@dvh91 dvh91 commented Oct 23, 2017

Description of the Changes

Following Preact Portal bug in explorer (developit/preact-portal#2),
implementing the workaround.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dvh91 dvh91 self-assigned this Oct 23, 2017
@dvh91 dvh91 requested a review from dan-ziv October 23, 2017 05:38
@OrenMe OrenMe merged commit 671ffa7 into master Oct 23, 2017
@OrenMe OrenMe deleted the FEC-7312 branch October 23, 2017 15:02
@OrenMe OrenMe mentioned this pull request Apr 3, 2019
Merged
5 tasks
OrenMe added a commit that referenced this pull request Apr 3, 2019
@OrenMe
fix(FEC-9003): can't close share overlay on IE11 (#379)
a38f4f6 
See #95 as it is basically the same issue :-(
Also fixed it for smart container as it will now be rendered on desktops(and hence IE11) when player is very small.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@dvh91 dvh91

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dvh91 @OrenMe