fix(FEC-7324): slider touch support #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrenMe
reviewed
Oct 23, 2017
| else if (e.changedTouches) { clientX = e.changedTouches[0].pageX } | ||
| else { clientX = e.clientX; } | ||
|
|
||
| let offsetLeft = clientX - this._sliderElement.getBoundingClientRect().left; |
There was a problem hiding this comment.
Isn't accessing getBoundingClientRect a performance hit?
There was a problem hiding this comment.
There's actually a better way to implement it with fewer calls to getBoundingClientRect. calculate the getBoundingClientRect only when player size is changed.
Will change the PR tomorrow
down event instead of any mouseup/move events.
OrenMe
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Support of touch move of slider component
CheckLists