Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change media with ads #98

Merged
merged 7 commits into from
Oct 24, 2017
Merged

feat: change media with ads #98

merged 7 commits into from
Oct 24, 2017

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Oct 23, 2017 •
edited

Description of the Changes

When change media is started, resets the ui state so we will see smooth transition to the next preset.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Oct 23, 2017
@dan-ziv dan-ziv requested review from OrenMe and dvh91 October 23, 2017 17:55
@OrenMe OrenMe merged commit f066a50 into master Oct 24, 2017
@OrenMe OrenMe deleted the change-media-with-ads branch October 24, 2017 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvh91 dvh91 dvh91 approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

Assignees

@dan-ziv dan-ziv

Labels
Priority: High Type: Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dan-ziv @dvh91 @OrenMe