Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: volume muted on player init bug fix #99

Merged
merged 2 commits into from
Oct 24, 2017
Merged

fix: volume muted on player init bug fix #99

merged 2 commits into from
Oct 24, 2017

Conversation

dvh91
Copy link

@dvh91 dvh91 commented Oct 24, 2017

Description of the Changes

mouseup handler logic should be executed only when dragging status is true

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dvh91 dvh91 self-assigned this Oct 24, 2017
@dvh91 dvh91 requested a review from OrenMe October 24, 2017 06:41
@dan-ziv dan-ziv merged commit 506f935 into master Oct 24, 2017
@dan-ziv dan-ziv deleted the volume-muted-bug branch October 24, 2017 06:52
@OrenMe
Copy link
Contributor

OrenMe commented Oct 24, 2017

closes FEC-7332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

Assignees

@dvh91 dvh91

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dvh91 @OrenMe @dan-ziv