Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: subtitles font size is too small on mobile #270

Merged
merged 2 commits into from
Jul 25, 2018
Merged

fix: subtitles font size is too small on mobile #270

merged 2 commits into from
Jul 25, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jul 25, 2018

Description of the Changes

Change the font size percent to be closer to the native.
Fixed also by kaltura/playkit-js-ui#257

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Jul 25, 2018
@yairans yairans requested a review from OrenMe July 25, 2018 09:26
@yairans yairans changed the title fix: align subtitles font size to the native fix: subtitles font size is too small on mobile Jul 25, 2018
@yairans yairans merged commit f6489ed into master Jul 25, 2018
@yairans yairans deleted the font-size branch July 25, 2018 10:12
yairans added a commit to kaltura/playkit-js-ui that referenced this pull request Jul 25, 2018
Set the captions offset on hovering to 50px instead of 60px.
Fixed also by kaltura/playkit-js#270
borhandarabi pushed a commit to TasvirChi/playchi-js-ui that referenced this pull request May 15, 2024
Set the captions offset on hovering to 50px instead of 60px.
Fixed also by kaltura/playkit-js#270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants