pkg/kamailio/deb: libxmlrpc-c3-dev becomes libxmlrpc-core-c3-dev on debian buster

[khorsmann]

Description

Hi all,
make deb on debian buster should make kamailio packages. The libxmlrpc-c3-dev seems renamed to libxmlrpc-core-c3-dev.

Troubleshooting

Reproduction

git clone kamailio
cd kamailio
git checkout 5.4
make deb

Debugging Data

pi@pi:~/src/kamailio (5.4=)$ make deb
make -C src/ deb
make[1]: Entering directory '/home/pi/src/kamailio/src'
target architecture <arm6>, host architecture <arm7>
making config...
(cd ..; \
if [ -d debian ]; then \
        dpkg-buildpackage -rfakeroot -tc -uc -us; \
        rm debian; \
else \
        ln -s pkg/kamailio/deb/debian debian; \
        dpkg-buildpackage -rfakeroot -tc -uc -us; \
        rm debian; \
fi)
dpkg-buildpackage: info: source package kamailio
dpkg-buildpackage: info: source version 5.4.0
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Victor Seva <vseva@debian.org>
dpkg-buildpackage: info: host architecture armhf
 dpkg-source --before-build .
dpkg-checkbuilddeps: error: Unmet build dependencies: libxmlrpc-c3-dev
dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; aborting
dpkg-buildpackage: warning: (Use -d flag to override.)
make[1]: Leaving directory '/home/pi/src/kamailio/src'

Log Messages

(paste your log messages here)

SIP Traffic

(paste your sip traffic here)

Possible Solutions

pi@pi:~/src/kamailio (5.4-patch-libxmlrpc-core)$ git diff HEAD HEAD^
diff --git a/pkg/kamailio/deb/debian/backports/buster b/pkg/kamailio/deb/debian/backports/buster
index 8ccfda1db2..82a41a8d4f 100755
--- a/pkg/kamailio/deb/debian/backports/buster
+++ b/pkg/kamailio/deb/debian/backports/buster
@@ -7,7 +7,7 @@ rm -rf ${DIST}
 cp -r debian ${DIST}

 # No mi_xmlrpc module
-sed -i -e '/libxmlrpc-core-c3-dev/d' -e '/^Package: kamailio-xmlrpc-modules/,/^$/d' \
+sed -i -e '/libxmlrpc-c3-dev/d' -e '/^Package: kamailio-xmlrpc-modules/,/^$/d' \
        ${DIST}/control
 sed -i -e 's/ mi_xmlrpc[ ,$]*/ /' ${DIST}/rules
 sed -i -e '/^EXTRA_EXCLUDED_MODULES=/s/$/ mi_xmlrpc/' ${DIST}/rules
diff --git a/pkg/kamailio/deb/debian/control b/pkg/kamailio/deb/debian/control
index a423d6c70c..52957ddabc 100644
--- a/pkg/kamailio/deb/debian/control
+++ b/pkg/kamailio/deb/debian/control
@@ -49,7 +49,7 @@ Build-Depends:
  libunistring-dev,
  libval-dev,
  libxml2-dev,
- libxmlrpc-core-c3-dev,
+ libxmlrpc-c3-dev,
  openssl,
  pkg-config,
  python,
diff --git a/utils/db_berkeley/kambdb_recover b/utils/db_berkeley/kambdb_recover
deleted file mode 100755
index 88d06da872..0000000000

Additional Information

• Kamailio Version - output of kamailio -v

kamailio -v
version: kamailio 5.4.0 (arm6/linux) a24d6c-dirty
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: a24d6c -dirty
compiled with gcc 8.3.0

• Operating System:

pi@pi:~/src/kamailio (5.4-patch-libxmlrpc-core)$ lsb_release -a
No LSB modules are available.
Distributor ID: Raspbian
Description:    Raspbian GNU/Linux 10 (buster)
Release:        10
Codename:       buster

lsb_release -a
No LSB modules are available.
Distributor ID: Debian
Description:    Debian GNU/Linux 10 (buster)
Release:        10
Codename:       buster

[miconda]

I do not think we still need libxmlrc-c3 in any of the modules we package, it was for the old mi_xmlrpc module, removed since 5.0. Grepping, I see an internal tool using it, pike_top, but we do not package it and and I am not sure why is useful for, likely kamctl/kamcmd/kamcli can replace it to do rpc command for dumping pike internal tree.

Maybe @linuxmaniac can check this build dependency.

[linuxmaniac]

@khorsmann if you're building from source, it's better to select the flavor you need:

# git clone <kamailio_url>
# cd kamailio
# git checkout 5.4
# ln -s pkg/kamailio/deb/<deb_flavor> debian
# make deb

[khorsmann]

@linuxmaniac thanks for the hint. I saw that you changed the default flavor to buster.
Should there an hint somewhere in the kamailio docs to give that hint for other users?