Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: cannot merge config files on system with ostree #3252

Closed
sergey-safarov opened this issue Sep 26, 2022 · 4 comments
Closed

packaging: cannot merge config files on system with ostree #3252

sergey-safarov opened this issue Sep 26, 2022 · 4 comments
Assignees
Labels
expired pkg packaging related Stale

Comments

@sergey-safarov
Copy link
Member

On Fedora Core when installed Kamailio and then installed additional packages then receive error

[root@caloes-1 ~]# journalctl -flu ostree-boot-complete.service -o cat
Starting ostree-boot-complete.service - OSTree Complete Boot...
error: ostree-finalize-staged.service failed on previous boot: During /etc merge: Modified config file newly defaults to directory 'kamailio', cannot merge
ostree-boot-complete.service: Main process exited, code=exited, status=1/FAILURE
ostree-boot-complete.service: Failed with result 'exit-code'.
Failed to start ostree-boot-complete.service - OSTree Complete Boot.
ostree-boot-complete.service - OSTree Complete Boot was skipped because all trigger condition checks failed.
ostree-boot-complete.service - OSTree Complete Boot was skipped because all trigger condition checks failed.
ostree-boot-complete.service - OSTree Complete Boot was skipped because all trigger condition checks failed.

Suggestion place default Kamailio config into dedicated package "kamailio-config-default".

@sergey-safarov sergey-safarov self-assigned this Sep 26, 2022
@sergey-safarov sergey-safarov added the pkg packaging related label Sep 26, 2022
@miconda
Copy link
Member

miconda commented Sep 27, 2022

Can you present in more details what exactly the problem is? From the logs (and not a fedora user) is hard to figure out.

@sergey-safarov
Copy link
Member Author

This is not related to C source code.
This is related to the file system used by OS.
https://en.wikipedia.org/wiki/OSTree

I think, more prefer to use CFGFILE variable in the /etc/sysconfig/kamailio to define a custom config file, like

[root@ip-100-85-120-8 ~]# head /etc/sysconfig/kamailio 
CFGFILE=/etc/sbc/kamailio.cfg

#
# Kamailio startup options
#

# Amount of shared memory to allocate for the running Kamailio server (in Mb)
SHM_MEMORY=128

# Amount of per-process (package) memory to allocate for Kamailio (in Mb)

And when I "upgrade" or "install" packages then it will not conflict with files (symbolic links) manually placed on the file system.

@miconda
Copy link
Member

miconda commented Oct 4, 2022

IMO, at least the default config should be part of main kamailio package, it is how most packages do afaik (ok, on debian/ubuntu). Maybe that is going to be changed, but for the moment it seems to be the norm.

On the other hand, I am not leveraging the packages that much, if something new is required by recent distros, then I am open to changes if there are not objections from others or better proposals.

Copy link

github-actions bot commented Nov 8, 2023

This issue is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.

@github-actions github-actions bot added the Stale label Nov 8, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expired pkg packaging related Stale
Projects
None yet
Development

No branches or pull requests

2 participants