Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos https://kamailio.org/docs/db-tables/kamailio-db-devel.html #3361

Closed
dilyanpalauzov opened this issue Feb 6, 2023 · 3 comments
Closed

Comments

@dilyanpalauzov
Copy link
Contributor

https://kamailio.org/docs/db-tables/kamailio-db-devel.html#idm9040 contains:

  • thay instead of they, (UID_AUTH_DB Module)
  • ,if without comma in between (in UAC Module)
  • for table "uacreg" column realm is described as “Remote username”, it should be Remote realm

For table dbaliases indexes contains:

  • alias_user_idx on column alias_username
  • alias_idx composite index on columns alias_username and alias_domain

I would say the composite index will also be used on queries only on the alias_username column, so the index alias_user_idx is redundant and should be deleted.

@miconda
Copy link
Member

miconda commented Feb 6, 2023

Those files are generated from xml schema files in the source tree at src/lib/srdb1/schema/.

While the first column on a composite index has some benefits on queries using it along with some database systems, it is not as efficient as with a dedicated index. I would not change that in the definition of the table, anyhow on database intensive systems, one should consult a database admin to tune properly the structure and the indexes.

@dilyanpalauzov
Copy link
Contributor Author

Thanks for your answer. Since December there is no ,if without space in between in the source code, but on the above webpage ,if does exist.

@miconda
Copy link
Member

miconda commented Feb 7, 2023

Those documents are not automatically generated, usually being done when a new major release is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants