Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

append_fromtag on upstream in-dialog requests #536

Closed
schoberw opened this issue Mar 9, 2016 · 3 comments
Closed

append_fromtag on upstream in-dialog requests #536

schoberw opened this issue Mar 9, 2016 · 3 comments

Comments

@schoberw
Copy link
Contributor

schoberw commented Mar 9, 2016

Record-Routing in in-dialog request are not needed by RFC 3261. But there are many clients out there not sending initial route-set in in-dialog requests. To provided them with the initial route-set together with UAC modified requests the ;ftag parameter must be the to-tag on upstream requests.
append_fromtag parameter added the tag value from "from" header always, even on upstream. This is fixed here.

It is not done on record_route_preset(). This should not be called on record routing anyway.

rr_record.c.patch.txt

@miconda
Copy link
Member

miconda commented Mar 9, 2016

Can you make a pull request via github? In that way is easy to review and merge, plus Travis-CI will compile the patch to be sure it works fine on many distros.

@schoberw
Copy link
Contributor Author

schoberw commented Mar 9, 2016

Hi!

It seems I’ve done it wrong. I did a fork and then a pull request. This is obviously not seen by others. Right?
schoberw#1

Can you pls help me doing it right?

Thanks!
Br
Walter

@schoberw
Copy link
Contributor Author

schoberw commented Mar 9, 2016

Thank you all! Done!

@schoberw schoberw closed this as completed Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants