Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout param added in ndb_redis module #557

Closed
misaksen opened this issue Mar 31, 2016 · 5 comments
Closed

Timeout param added in ndb_redis module #557

misaksen opened this issue Mar 31, 2016 · 5 comments

Comments

@misaksen
Copy link

The connection timeout was hardcoded to 1 sec. This can now be set from cfg file.

If the redis server became unresponsive kamailio would wait for the standard Linux TCP timeout for an answer (very long time).

This patch has added an timeout value for redis commands.

The default timeout is 1 sec.
30-redis-timeout.txt

@misaksen
Copy link
Author

misaksen commented Apr 1, 2016

We have found a few issues with this patch. I will send a new patch later.

@miconda
Copy link
Member

miconda commented Apr 1, 2016

It is better to make a pull request, in that way the patch can be reviewed directly on github and it is compiled to see if it rises any issues. After that, merging the patch is just one click.

@misaksen
Copy link
Author

misaksen commented Apr 1, 2016

Hi Daniel,

OK. I will try to do that with the next patch.

/Morten

@misaksen
Copy link
Author

misaksen commented Apr 1, 2016

Pull request #559 created.

@miconda
Copy link
Member

miconda commented Apr 1, 2016

Closing this one an continuing on the pull request if there is anything else to be discussed.

@miconda miconda closed this as completed Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants