Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsq module doc #905

Closed
oej opened this issue Jan 2, 2017 · 2 comments
Closed

nsq module doc #905

oej opened this issue Jan 2, 2017 · 2 comments

Comments

@oej
Copy link
Member

oej commented Jan 2, 2017

  • Please add more details on the dependency libraries.
  • There are also a lot of spelling errors
  • Document return value of function
  • Event routes needs to have their own section (like other modules) and not only be mentioned in the introduction
  • There is no real explanation of what the transformation actually does, please add some text
  • The pseudo variable needs an explanation too, there is obviously some syntax to it with two arguments

Thank you for updating this in good time for the coming release!

@eschmidbauer
Copy link
Contributor

@oej
I've submitted a PR for this issue
#921
please review. If i missed anything, can you please point out where?
Thanks,
Emmanuel

@oej
Copy link
Member Author

oej commented Jan 10, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants