Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detailed Subscription/@live and Defer/Stream usage data #3290

Open
1 of 6 tasks
Tracked by #3858
n1ru4l opened this issue Nov 6, 2023 · 2 comments
Open
1 of 6 tasks
Tracked by #3858

Detailed Subscription/@live and Defer/Stream usage data #3290

n1ru4l opened this issue Nov 6, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request that adds new things or value to Hive

Comments

@n1ru4l
Copy link
Collaborator

n1ru4l commented Nov 6, 2023

We do not collect any usage data for subscriptions and defer/stream.

Instead of HTTP request duration, we can monitor average Subscription length.

Useful metrics to track:

  • Number of subscriptions on a Subscription Root field
  • Number of payloads sent/values published for a subscription root field
  • Subscription connection duration/length
  • Error rate while setting up a subscription on a subscription root field
  • Error rate for published subscription payloads per subscription root field
  • Protocol used for a subscription operation (WS, WS Legacy, SSE)
@n1ru4l n1ru4l added the enhancement New feature or request that adds new things or value to Hive label Nov 6, 2023
@maxbol
Copy link

maxbol commented Nov 8, 2023

This would be a great feature for us 👍

Would like to add that support for live queries via the @live directive would be huge for us, and I suppose that could share implementation with usage for defer/stream fairly easily (i.e. a general solution for query executions that return AsyncIterable)?

@n1ru4l n1ru4l changed the title Support Subscription and Defer/Stream usage data Support Subscription/@live and Defer/Stream usage data Nov 9, 2023
@theguild-bot theguild-bot mentioned this issue Jan 24, 2024
91 tasks
@n1ru4l n1ru4l self-assigned this Mar 8, 2024
@n1ru4l n1ru4l changed the title Support Subscription/@live and Defer/Stream usage data Subscription/@live and Defer/Stream usage data Mar 26, 2024
@n1ru4l n1ru4l changed the title Subscription/@live and Defer/Stream usage data Detailed Subscription/@live and Defer/Stream usage data Mar 26, 2024
@n1ru4l
Copy link
Collaborator Author

n1ru4l commented Mar 26, 2024

With #4176, we now support basic subscription usage reporting for conditional breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request that adds new things or value to Hive
Projects
None yet
Development

No branches or pull requests

2 participants