Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OIDC Connect Discovery document #716

Open
Tracked by #3858
kamilkisiela opened this issue Nov 30, 2022 · 4 comments
Open
Tracked by #3858

Support OIDC Connect Discovery document #716

kamilkisiela opened this issue Nov 30, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request that adds new things or value to Hive

Comments

@kamilkisiela
Copy link
Owner

Spec: https://openid.net/specs/openid-connect-discovery-1_0.html#rfc.section.4.2
User could provide a link to the doc, pass a client id and a secret.

Why? Not all OIDC providers follow the same convention for endpoints. Azure AD has /userinfo under a different host.

@kamilkisiela kamilkisiela self-assigned this Dec 5, 2022
@n1ru4l
Copy link
Collaborator

n1ru4l commented Dec 6, 2022

okay so people will put it into a form on the hive settings website http://brrrrrt/.well-known/openid-configuration
we will fetch a JSON file from that and that will be used instead of the OAuth API Url that is now used by everything.

Things to touch:

  • Database Schema (Store discovery document url)
  • GraphQL API (store discovery document instead of oauth_api_url)
  • Web APP UI
  • supertokens backend config on app service

@n1ru4l
Copy link
Collaborator

n1ru4l commented Jan 19, 2023

Right now we already introduced support for more granular configuration via the UI through #835

@n1ru4l n1ru4l added the enhancement New feature or request that adds new things or value to Hive label Nov 6, 2023
@wethekings303
Copy link

Would this support OIDC login for any provider that uses oauth such as keycloak? Right now OIDC only supports google, okta, and github - https://the-guild.dev/graphql/hive/docs/self-hosting/oidc-login.

We currently use organization scoped SSO - https://the-guild.dev/graphql/hive/docs/management/sso-oidc-provider. This allows sso after sso integration was setup manually through the UI using the settings referenced at - #835. It would be great if from the initial deployment we could use SSO.

@n1ru4l
Copy link
Collaborator

n1ru4l commented Jan 17, 2024

@wethekings303 This issue tracks supporting OIDC Discovery documents for organizations. ANY OIDC Compliant provider can be connected to an organization (see https://the-guild.dev/graphql/hive/docs/management/sso-oidc-provider).

You are referring to a self-hosted OIDC login.

Regarding

It would be great if from the initial deployment we could use SSO.

This will be covered via the admin API #2994

@theguild-bot theguild-bot mentioned this issue Jan 24, 2024
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request that adds new things or value to Hive
Projects
Status: Future
Development

No branches or pull requests

3 participants