Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All keycodes are unrecognized #25

Closed
nyovaya opened this issue May 30, 2019 · 11 comments
Closed

All keycodes are unrecognized #25

nyovaya opened this issue May 30, 2019 · 11 comments

Comments

@nyovaya
Copy link

nyovaya commented May 30, 2019

I tried version 0.7.1 and upstream git.
Every key I try to use is an "Unknown keycode".
Tried with alacritty, mate-terminal, xterm.

@nyovaya
Copy link
Author

nyovaya commented May 30, 2019

Config files were placed wrongly.

@nyovaya nyovaya closed this as completed May 30, 2019
@kamiyaa
Copy link
Owner

kamiyaa commented May 30, 2019

On that note, the dev branch has changed the way keycodes are mapped, so that modifier keys can be mapped (Ctrl, Alt, Shift, etc.)
See https://github.com/kamiyaa/joshuto/blob/dev/config/keymap.toml
And #4

@nyovaya
Copy link
Author

nyovaya commented May 30, 2019

Ive seen that - but I also had the issue that I cant use backspace when renaming files it creates a 'ć' instead.

@kamiyaa
Copy link
Owner

kamiyaa commented May 30, 2019

Yes, that is a problem I've noticed when using joshuto on other setups. There will probably be a configuration for certain keys because keyboards have different keycodes for some keys.

@kamiyaa
Copy link
Owner

kamiyaa commented May 31, 2019

@nifker see keymap.rs struct (added in dev 3cba2ba) and keymap.toml example

@nyovaya
Copy link
Author

nyovaya commented May 31, 2019

@kamiyaa ok that works now but I think it will be better for most users if it works out-of-the-box for both configurations.

@kamiyaa
Copy link
Owner

kamiyaa commented Jun 1, 2019

@nifker out-of-the-box for both configurations?

@nyovaya
Copy link
Author

nyovaya commented Jun 1, 2019

@kamiyaa so that backspace works whether even when they dont change their config, on different system which where the code for BS slightly differs.

@kamiyaa
Copy link
Owner

kamiyaa commented Jun 1, 2019

@nifker bfb110a should allow backspace to work on 99% of cases. Thanks for the feedback 👍

@nyovaya
Copy link
Author

nyovaya commented Jun 1, 2019

@kamiyaa thats working too. Very neat file manager :D
Ill post some other improvement soon too. Ill try to get into the code base and see if I can do some improvements too.

@kamiyaa
Copy link
Owner

kamiyaa commented Jun 1, 2019

@nifker awesome! :D
The code base is quite messy right now with questionable designs 😅
Feel free to make big changes to it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants