Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file deletion asks for capital Y for confirmation but reacts on lowercase y #68

Closed
DLFW opened this issue Jun 10, 2021 · 2 comments
Closed

Comments

@DLFW
Copy link
Contributor

DLFW commented Jun 10, 2021

When deleting a file (dD), joshuto asks:

Delete 1 files? (Y/n)

which indicates that only a capital Y confirms deletion. Instead, a capital Y aborts deletion but instead a lowercase y confirms the deletion.

Is it a spelling mistake in the prompt or is the check implemented wrong? What's the desired behavior?

@CosmicHorrorDev
Copy link

The general rule of thumb for prompts like that is that the capitalized option represents the default so I would assume that inputting nothing would also delete.

However, I do think that Y should be accepted as y and N as n

@DLFW
Copy link
Contributor Author

DLFW commented Jun 10, 2021

Oh, yes. Just saw that ranger asks with (y/N). Never recognized that. (BTW, "no" as default somehow makes more sense to me... anyway, different story...)
Thanks!

@DLFW DLFW closed this as completed Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants