New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic jmx importing #401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hunterpayne-ck I really like the idea!!! I left some comments and I think that we need some tests and an example of configuration.. and of course doc in our site WDYT?
@@ -0,0 +1,362 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hunterpayne-ck please add the kamon copyright in each file
val metricType: MetricTypeEnum.MetricType, val name: String, | ||
unitOfMeasure: UnitOfMeasurement, // = UnitOfMeasurement.Unknown, | ||
range: DynamicRange = null, | ||
refreshInterval: FiniteDuration = null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why you use null values instead of Options values?
Great, thank you. Use of null is probably an oversight. I often switch between Java and Also, the Kamon unit tests seem to fail intermittently on tests in modules Hunter On Thu, Oct 13, 2016 at 12:46 PM, Diego Parra notifications@github.com
|
@hunterpayne-ck we are some issues with the tests and travis.. |
The requested changes have been made |
Ok, finally found time to make the requested changes for this PR. Nulls Hunter On Fri, Oct 14, 2016 at 7:21 AM, Diego Parra notifications@github.com
|
@hunterpayne-ck the changes are ok, but maybe is a good idea make a test. WDYT? |
Ok, some tests...will be a while until I can find the time to write them. We test them at CK using an integration test against a staging monitoring stack so we haven't needed them so far. But Kamon can't do that so we probably need unit tests here. |
So I've been writing a test for this PR but have run into a significant Perhaps we should try to get that one merged first as it makes testing much Hunter On Tue, Oct 25, 2016 at 11:48 AM, Diego Parra notifications@github.com
|
…c conversions in the code
So I got an unit test working...but its hard to have a good test suite without being able to run kamon with different configs. So this could use more testing but at least it has a basic positive unit test. Until PR #403 is merged in, doing lots of negative unit tests will be difficult. Will revisit after that happens. |
Hey, we got a good build...can you merge this PR now? |
@hunterpayne-ck the PR looks good for me. I would like to merge it BUT there is one missing piece, not in this repository but in our documentation website! yes, I know, it is a bit boring to write docs but it is a necessary thing... so if you could change the jmx-documentation documentation in oder to reflect this change it would be amazing. |
Can I do that in a separate PR on this branch? We have a good build and I Hunter On Mon, Nov 7, 2016 at 10:49 AM, Diego Parra notifications@github.com
|
@hunterpayne-ck please make a new PR here: https://github.com/kamon-io/kamon.io/blob/master/backends/jmx.md |
Done...kamon-io/kamon.io#27 |
@hunterpayne-ck thanks for this PR. Done!!! |
This is new functionality for Kamon. It allows importing of custom JMX metrics. The JMX metrics to import are specified in a config file and pumped into kamon just like any other metric. Then those metrics can be sent to any Kamon backend. Great for places that use Kamon and also older systems (like Kafka) that export their metrics via JMX. Also, many other parts of Kamon could be refactored to use this module instead of using custom code to access specific JMX metrics.