Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default metrics buckets for kamon-system-metrics are too small #1232

Open
jatcwang opened this issue Dec 7, 2022 · 2 comments
Open

Default metrics buckets for kamon-system-metrics are too small #1232

jatcwang opened this issue Dec 7, 2022 · 2 comments

Comments

@jatcwang
Copy link
Contributor

jatcwang commented Dec 7, 2022

https://github.com/kamon-io/Kamon/blob/7f806223406e9d9a8cb57334975f80afa438ad1c/reporters/kamon-prometheus/src/main/resources/reference.conf

The default buckets sizes are too small to provide useful information since all the collected values are put into the largest bucket which is currently any value > 1MB (e.g. jvm.memory.used)

I think a good way to address this is to add per-metric override in kamon-system-metrics' reference.conf.
If you're happy with this solution I'll raise a PR :) Thanks

@jatcwang jatcwang changed the title Default buckets for kamon-system-metrics are too small Default metrics buckets for kamon-system-metrics are too small Dec 7, 2022
@ivantopo
Copy link
Contributor

Hey @jatcwang, that would be lovely! This is something I wanted to do for quite some time but just didn't find the time to do so. That PR would be more than welcome 🙏

@ivantopo
Copy link
Contributor

Just one note: probably it makes more sense to add those settings on the kamon-prometheus' reference conf instead of system metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants