Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NullPointerException on the Kafka Consumer instrumentation #1267

Closed
ivantopo opened this issue Mar 27, 2023 · 0 comments · Fixed by #1269
Closed

NullPointerException on the Kafka Consumer instrumentation #1267

ivantopo opened this issue Mar 27, 2023 · 0 comments · Fixed by #1269
Labels
Enterprise Support Marks issues with higher priority due to Enterprise/APM support agreements

Comments

@ivantopo
Copy link
Contributor

A Kamon APM user reported the issue below. I think it is related to having the Kafka Consumer instrumentation enabled but the consumed messages don't have the Kamon Context.

java.lang.NullPointerException: Cannot invoke "kamon.context.Context.get(kamon.context.Context$Key)" because "incomingContext" is null
at kamon.instrumentation.kafka.client.KafkaInstrumentation$.consumerSpan(KafkaInstrumentation.scala:185)
at kamon.instrumentation.kafka.client.KafkaInstrumentation$.runWithConsumerSpan(KafkaInstrumentation.scala:126)
at kamon.instrumentation.kafka.client.KafkaInstrumentation$.runWithConsumerSpan(KafkaInstrumentation.scala:106)
@ivantopo ivantopo added the Enterprise Support Marks issues with higher priority due to Enterprise/APM support agreements label Mar 27, 2023
ivantopo added a commit that referenced this issue Mar 27, 2023
@ivantopo
guard against missing context in consumer records, fixes #1267
60b2726
@ivantopo ivantopo linked a pull request Mar 27, 2023 that will close this issue
Fix NPE on consumer instrumentation, fixes #1267 #1269
Merged
ivantopo added a commit that referenced this issue Mar 29, 2023
@ivantopo
guard against missing context in consumer records, fixes #1267
eafad20
ivantopo added a commit that referenced this issue Mar 29, 2023
@ivantopo
guard against missing context in consumer records, fixes #1267
02a2c8c
ivantopo added a commit that referenced this issue Apr 4, 2023
@ivantopo
Merge pull request #1269 from kamon-io/npe-on-consumer-instrumentation
f464db1 
Fix NPE on consumer instrumentation, fixes #1267
solnaranu pushed a commit to solnaranu/Kamon that referenced this issue May 25, 2023
@ivantopo
guard against missing context in consumer records, fixes kamon-io#1267
abb5355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enterprise Support Marks issues with higher priority due to Enterprise/APM support agreements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix NPE on consumer instrumentation, fixes #1267 kamon-io/Kamon
1 participant
@ivantopo