ClassCastException when using NewRelicErrorLogger without the aspectj weaver

[ivantopo]

When a application is configured to use the NewRelicErrorLogger but wasn't started with the aspectj weaver the class cast fails and the error loops back into the logger, producing a infinite failure loop that eventually kills the app.

When the application is not instrumented this logger should report the error anyway, missing the TraceToken information.

Exception:
flights-catalog java.lang.ClassCastException: akka.event.Logging$Error cannot be cast to kamon.trace.TraceContextAware
flights-catalog at kamon.newrelic.NewRelicErrorLogger.notifyError(NewRelicErrorLogger.scala:33) ~[kamon-newrelic-0.3.0.jar:0.3.0]

[ivantopo]

Also a warning should be logged to let the user know that probably forgot to include the weaver jvm options when starting the app.

[magro]

We're running into this issue when running tests (our tests / fake app is not instrumented):

2014-12-09 14:09:21,232 ERROR [undefined][akka://KeepJobLockedSpec/system/log2-NewRelicErrorLogger] [KeepJobLockedSpec-akka.actor.default-dispatcher-6] akka.actor.OneForOneStrategy - akka.event.Logging$Error cannot be cast to kamon.trace.TraceContextAware
java.lang.ClassCastException: akka.event.Logging$Error cannot be cast to kamon.trace.TraceContextAware
        at kamon.newrelic.NewRelicErrorLogger$$anonfun$notifyError$1.apply$mcV$sp(NewRelicErrorLogger.scala:44) ~[kamon-newrelic_2.11-0.3.6-20aefb53cae46417335ede27abdb9024b21c4496.jar:0.3.6-20aefb53cae46417335ede27abdb9024b21c4496]

Looking at NewRelicErrorLogger.scala:44 there's (again) an unguarded val ctx = error.asInstanceOf[TraceContextAware].traceContext. Is this a regression, because this should be fixed by commit 6e22e6e?

[ivantopo]

You are absolutely right, let me fix that quickly.

[ivantopo]

@magro done, published 0.3.6-1b508ff95ea477387a0b27eae41ee7a76861928e for Scala 2.11 in our snapshots repo, have fun!

[magro]

@ivantopo Great, works nicely.