Navigating away while transitioning sets incorrect scroll position

[MartinMuzatko]

When navigating away from a popup (using the arrow keys) in the middle of an animation to scroll to the visible popup, there is no other scroll event happening to get the correct focus.

[kamranahmedse]

Hey @MartinMuzatko could you please test if it is fixed now?

[MartinMuzatko]

Is it already deployed to the website? Then it is not working yet :)
I'll install it locally and test it.

[kamranahmedse]

It is deployed. yes please and maybe try to debug this section :)

[moghya]

@kamranahmedse @MartinMuzatko I think this is happening because we are choosing (please check here) postion to scroll as middle on the basis of absoluteElementTop and window.pageYOffset. When we're navigating away our element is already very close to the bottom of window i.e window.pageYOffset. and this way our middle is also very close to window.pageYOffset and we're loosing the entire point of scrolling to the middle of element.

I'll try to fix this. Any inputs from your side ?

P.S
Another thing affecting is popoverElement.bringInView(); call done before highlightedElement.bringInView(); call. I tried to commenting popoverElement.bringInView(); and now elements were always in middle of the screen, just that sometimes popoverElement were not in view.

[moghya]

@kamranahmedse @MartinMuzatko I'm extremely sorry, all the things I talked above were my misunderstandings,

Actual problem is ** popoverElement.bringInView(); is never bringing popover in the view**

I did little a small change for debugging,

if (popoverElement && !popoverElement.isInView()) {
      popoverElement.bringInView();

      //added this if to check effect of bringInView() call
      if (!popoverElement.isInView()) {
          console.log('it was not in view and still not in view');
      }
}

every time when popover was not in view, bringInView() failed to bring it inView.

[moghya]

@kamranahmedse @MartinMuzatko surprisingly adding following code fixed it, though this is not a good way to fix it.

while (!this.isInView()) {
    this.bringInView();
}

[kamranahmedse]

Fixed in 62c2a38. Should be fine now.

[moghya]

@kamranahmedse I'm sorry but that still leaves bug present in here

[kamranahmedse]

@moghya no, there is not.

The issue was related to the scroll, previously we had smooth scroll so it did not immediately scroll to the highlighted element; and if user switches the active element during the scroll, the next scroll was ignored because of the previous scroll being in progress. I just changed it to be instant to make it immediately scroll to the element.

The one that you are referring to, it is already instant and has no issues.