Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dev dependencies #348

Closed
wants to merge 9 commits into from
Closed

Conversation

mlisowsk
Copy link

@mlisowsk mlisowsk commented Dec 2, 2022

Hi Kamran,

I couldn't get driver.js to build on my system which has no python 2.x Therefore I

  • updated the devDependencies in package.json so it will build on a system with python 3.10
  • had to fix the webpack.config file due to changes in postcss-loader options format.
    • I also added a babel-loader config that maintains compatibility with MS WebBrowser control (~IE8), which the previous release had
  • new CHANGELOG file in a separate commit (feel free to omit)

Cheers, Martin

… @babel/preset-env.

Fix webpack.config.prod.js: added postcssOptions object; added babel-laoder presets for compatibility with MS WebBrowser control (IE8).
…scrollable container that is not BODY.

element.js: use scrollIntoViewIfNeeded().
onHighlighted() unconditionally call bringInView() - don't use isInView() which is buggy.
added terser-webpack-plugin devDep for ^4.0.0
webpack.config: added optimization section with TerserPlugin
 Implement option.showButtons to support only showing specific buttons (PR kamranahmedse#177) kamranahmedse#177
 Buttons will be hidden, but layout will remain the same (i.e. other buttons won't move).
 Add babel-loader options to webpack.config.prod.js to target >= IE8
 Add terser-plugin to webpack.config.prod.js
@mlisowsk mlisowsk marked this pull request as draft December 5, 2022 21:43
@kamranahmedse
Copy link
Owner

Apologies for the radio silence, I got super busy and couldn't find time to maintain this project. We have started to actively use it at my current company and decided to rewrite it due to underlying implementation issues. It now has much simpler API and is feature rich as compared to the previous version.

Please have a look at the release docs for v1.0 and the documentation and do let me know if you face any issues. Thanks again for taking your time to submit the PR! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants