Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong positioning #50

Closed
thomasthiebaud opened this issue Mar 27, 2018 · 4 comments
Closed

Wrong positioning #50

thomasthiebaud opened this issue Mar 27, 2018 · 4 comments

Comments

@thomasthiebaud
Copy link

I have some positioning problem using the latest version of the library. This code

const driver = new Driver({ padding: 0 });
driver.defineSteps([{
  element: '#company-profile-display-name-input',
  popover: {
    title: 'Title on Popover',
    description: 'Body of the popover',
    position: 'top',
  },
}]);
driver.start();

with this html elements

<div class="row">
  <div class="large-12 columns">
    <label>
      {{"b2bsettingsapp.companysettings.information.form_settings_displayname" | translate }}
      <input
        id="company-profile-display-name-input"
        type="text"
        ng-model="businessUnitDetails.displayName"
        strip-html
      />
    </label>
  </div>
</div>

render like this

screen shot 2018-03-27 at 11 34 49

If I inspect the styles, there are correctly applied (not override by something else), but the top value seems wrong

@kamranahmedse
Copy link
Owner

kamranahmedse commented Mar 27, 2018

hey thomas, could you possibly create a reproducing plunker or share any public link?

@thomasthiebaud
Copy link
Author

I will try to do that. I found that the positioning is wrong until I resize the window. Once I resize it, everything looks ok

@thomasthiebaud
Copy link
Author

I found out why. It is an angular problem not related with the library

Starting driver once the DOM has finished rendering using this piece of code solved it.

$timeout(function () {
  //DOM has finished rendering
  driver.start();
});

@Juanperezc
Copy link

I have exactly de same problen with ionic 3 , the top position is wrong but when I click the popover ,
this seems to be arranged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants