New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onPrev, onNext and onDone event callbacks to element options #91
Conversation
`onPrev` and `onNext` callbacks options will trigger when the element is highlighted. `onStart` or `onDone` features can be implemented by test `options.isFirst` or `options.isLast` in the callbacks.
Only return true from callback will make the tour continue. that helps dev to determine if it'd be take a rest for the tour
Thanks for the PR. It has been added in 0.6 |
Hi, are these modifications on CDN version? I'm trying to use these callbacks but they are not firing. |
I'm using v0.9 but does not existed onDone, onClose |
@anhnguyen72 you can use |
Hi @kamranahmedse When will the onClose() or onDone() Function be available in the master? Would be extremely helpful! Best regards! |
How can I distinguish last step was successfuly done by "Done" button or closed by "Close" button? onNext will not work for "Done" button. @kamranahmedse hello, why that PR was closed? :( |
hi folks, stop to issue on this topic again. my implement in this pull is too smart to be merged. bye |
I'm using v0.9.8 but does not existed onDone, onClose (⊙︿⊙) |
Add
onPrev
,onNext
andonDone
callbacks options to element's options.onStart
features can be implemented by testoptions.isFirst
in the callbacks.fixed issues #51 and #69