Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onPrev, onNext and onDone event callbacks to element options #91

Closed
wants to merge 7 commits into from

Conversation

Yahasana
Copy link

@Yahasana Yahasana commented May 3, 2018

Add onPrev, onNext and onDone callbacks options to element's options. onStart features can be implemented by test options.isFirst in the callbacks.

image

fixed issues #51 and #69

Mofasa added 5 commits May 3, 2018 09:19
`onPrev` and `onNext` callbacks options will trigger when the element is highlighted.  `onStart` or `onDone` features can be implemented by test `options.isFirst` or `options.isLast` in the callbacks.
Only return true from callback will make the tour continue. that helps dev to determine if it'd be take a rest for the tour
@Yahasana Yahasana changed the title onPrev and onNext event callbacks to element options onPrev, onNext and onDone event callbacks to element options May 5, 2018
@kamranahmedse
Copy link
Owner

Thanks for the PR. It has been added in 0.6

@TiagoSilvaPereira
Copy link

TiagoSilvaPereira commented Apr 12, 2019

Hi, are these modifications on CDN version? I'm trying to use these callbacks but they are not firing.

@anhnguyen72
Copy link

Thanks for the PR. It has been added in 0.6

I'm using v0.9 but does not existed onDone, onClose

@maczyt
Copy link

maczyt commented Dec 11, 2019

@anhnguyen72 you can use onReset

@kevinoehme
Copy link

Hi @kamranahmedse When will the onClose() or onDone() Function be available in the master? Would be extremely helpful! Best regards!

@koutsenko
Copy link

How can I distinguish last step was successfuly done by "Done" button or closed by "Close" button?

onNext will not work for "Done" button.
onReset event triggers for both events.

@kamranahmedse hello, why that PR was closed? :(

@Yahasana
Copy link
Author

hi folks, stop to issue on this topic again. my implement in this pull is too smart to be merged. bye

@yymoni
Copy link

yymoni commented Jul 2, 2020

Thanks for the PR. It has been added in 0.6

I'm using v0.9.8 but does not existed onDone, onClose (⊙︿⊙)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants