Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Python solution of 685 Redundant Connection II might need to be improved. #5

Closed
sangheestyle opened this issue Dec 25, 2018 · 4 comments
Closed

The Python solution of 685 Redundant Connection II might need to be improved. #5

sangheestyle opened this issue Dec 25, 2018 · 4 comments

Comments

@sangheestyle
Copy link
Contributor

sangheestyle commented Dec 25, 2018 •
edited

Hi,

It seems that the Python solution of 685 Redundant Connection II might need to be improved because it doesn't work.

I wanted to contribute to the solution but I am still trying to solve the problem. :0
@kamyu104
Copy link
Owner

Thanks for notification. This has been fixed :).

@sangheestyle
Copy link
Contributor Author

@kamyu104 Awesome. I checked the solution and easy to expand from your UnionFind solutions.

Additionally, can I ask you a question?

Could you tell me the reason why we need y != y_root? Without it, it looks fine but I am wondering.

@kamyu104
Copy link
Owner

kamyu104 commented Dec 25, 2018 •
edited

After fixing it, we have skipped the edge which makes 2 parents. y != y_root is no longer required.

@sangheestyle
Copy link
Contributor Author

@kamyu104 I checked it. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sangheestyle @kamyu104