Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving reader macro tests to their respective steps #54

Closed
martinklepsch opened this issue Apr 1, 2015 · 2 comments
Closed

Comments

@martinklepsch
Copy link
Contributor

Currently quoting, metadata and similar things are tested in the step 1 tests.

As a user (lol) I expected that all tests will pass if I completed all tasks in step 1.

@kanaka
Copy link
Owner

kanaka commented Apr 8, 2015

So, I realized this morning why this won't work. Step 1 is unique from the following steps because it doesn't yet have eval. So it's the only place you can test reader/printer functionality directly.

# In step 1
user> `7
(quote 7)
# steps 2 - 6 give an error
# step 7
user> `7
7

So, while it's not ideal, I think having these tests in step1 and marked as optional/deferrable is probably the best option without adding significant complication in the test runner or in the steps (e.g. a command line option to disable evaluation, ugh).

Closing.

@kanaka kanaka closed this as completed Apr 8, 2015
@martinklepsch
Copy link
Contributor Author

Alright, that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants