Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Math.random() for WebSocketMain.swf is used twice? #69

Closed
EdSchouten opened this issue Jun 28, 2011 · 1 comment
Closed

Math.random() for WebSocketMain.swf is used twice? #69

EdSchouten opened this issue Jun 28, 2011 · 1 comment
Labels
bug fixed

Comments

@EdSchouten
Copy link
Contributor

Inspection of the code reveals that it should probably only be appended for Trident-like browsers only, but in fact it is appended to the URL twice. See websock.js, line 34-39.
@kanaka
Copy link
Member

kanaka commented Jun 28, 2011

Good catch. Fix in 0b7bc4e

@kanaka kanaka closed this as completed Jun 28, 2011
ncarrier pushed a commit to ncarrier/carino-packages-websockify that referenced this issue Mar 21, 2015
@kanaka
Only append random string to swf path in IE.
9a2b50d 
Issue novnc/noVNC#69

Thanks https://github.com/EdSchouten for the catch.
ncarrier pushed a commit to ncarrier/carino-packages-websockify that referenced this issue Mar 21, 2015
@kanaka
Remove extraneous question mark.
b590289 
Part of novnc/noVNC#69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kanaka @EdSchouten