Websockify new release

[nttdatainc-openstackers]

Greetings!!

You all must be knowing websockify project is used by the OpenStack Nova noVNC service for viewing virtual machine consoles and we intend to use this OpenStack service in our production deployment. Few months back, “use python logging module” feature was added to the websockify project in this #100 pull request and we want to this feature in OpenStack which will enable us to log messages from both Nova noVNC service and websockify library to the same log file. The latest websockify version v0.5.1 used by the OpenStack nova service doesn’t have the above feature.

Request you to please release new version of websocikfy project that will enable us to use “python logging module” feature.

Thanks in advance for your co-operation.

[astrand]

I think that a new release sounds like a good idea. However, we need to make sure that what we have now is stable. Has anybody been able to test the latest version (which includes pull request #111 for example) with OpenStack Nova?

[DirectXMan12]

@astrand it seems to work fine, last time I checked (about a week ago) -- it's used for devstack. I'll double check again today if I have some time and then we can tag a new release and all that jazz.

[nttdatainc-openstackers]

I have found 2 issues when I used latest websockify master in our OpenStack environment.

1. no_parent parameter is removed from websockify project so we will need to make necessary changes in the nova code to fix this issue.
2. When tried to connect to the vm vmc console , it fails to connect and gives error 1006.

[nttdatainc-openstackers]

I have added stacktrace I see in novncproxy when it fails to show the vm console in the below URL.
http://paste.openstack.org/show/64707/

[astrand]

Yes, no_parent should not be necessary, see https://github.com/kanaka/websockify/issues/83.

Wrt the stacktrace, what platform are you running on? I found http://bugs.python.org/issue1282647 which indicates that this is a problem with the underlying OS.

[nttdatainc-openstackers]

I'm on Ubuntu OS.
openstack@development-010:~$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=13.04
DISTRIB_CODENAME=raring
DISTRIB_DESCRIPTION="Ubuntu 13.04"

P.S. The latest release websockify 0.5.1 version has no issues. That means some changes are made to websockify that is causing this issue.

[DirectXMan12]

After a few updates to the Nova websocketproxy code (due to the refactoring), I can confirm that things seem to work fine in Fedora 20 (turns out before an update had gone wrong an not updated my copy of websockify, but it seems to be working fine now).

@nttdatainc-openstackers : this is the modified code that I'm using: https://gist.github.com/9011211 -- does it work for you? Also, can you double check to see if you're affected by the bug that @astrand posted?

[nttdatainc-openstackers]

I have applied your patch in my environment and now I can see the VM console.
Nice job!! Thanks for your help.

After the new version is released, if you want I can submit the above patch along with the changes necessary to enable websocket python logging in Nova.

[DirectXMan12]

@nttdatainc-openstackers : No problem! IMHO, those should actually be different patches to Nova (one merely updates the existing code to work with a new version, while the other introduces a change to take advantage of a new feature). I can submit my changes, if you want (I'm actually https://launchpad.net/~sross-7 upstream -- I work on the Red Hat OpenStack Nova team)

[nttdatainc-openstackers]

@DirectXMan12 : That's sound good to me. Thanks again.

[DirectXMan12]

@kanaka , @astrand : what should the new version number be? Since we broke backwards compat, it should fall in the "major" category. How does websockify do versioning? Once we figure that out, we can tag a new release, since it looks like things are working properly.

[astrand]

I don't know any details about the version numbers, but since the previous version was 0.5.1, I guess the new version could be called 0.6.0. (I wonder what happened to 0.5.0 though?)

[DirectXMan12]

New release is out: v0.6.0 ! Should we name it, though?

[DirectXMan12]

@kanaka: who has permission to push to the cheeseshop?

[nttdatainc-openstackers]

@DirectXMan12: Note sure if your patch [https://gist.github.com/9011211] will be accepted in the IceHouse release as the code freezing date has already been lapsed.

[DirectXMan12]

new release is up on PyPI. Closing this bug

[nttdatainc-openstackers]

Thank you everyone for your help!!!

[kanaka]

@DirectXMan12 realized that I never answered your question about versioning. I'm open to suggestions going forward, but what I've been doing is 0.X.Y where X is for potentially breaking API changes and Y is non-breaking changes. So 0.6.0 seems about right.