Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for React 18+ #50

Closed
unidesigner opened this issue Apr 6, 2023 · 5 comments · Fixed by #52
Closed

Support for React 18+ #50

unidesigner opened this issue Apr 6, 2023 · 5 comments · Fixed by #52
Assignees

Comments

@unidesigner
Copy link

Hi! I came across this very nice package, and I would like to integrate it into a platform for neuroscience research. Unfortunately, the platform requires 18. Are there any plans to update graphic-walker to support React 18? Thank you.

@ObservedObserver
Copy link
Member

Sure, react 18 ecosystem is stable enough now; we will add support to it soon.

@ObservedObserver ObservedObserver self-assigned this Apr 7, 2023
@ObservedObserver
Copy link
Member

ObservedObserver commented Apr 10, 2023

Hi, graphic-walker now supports react18+ (since v0.3.1), you can try it now.

For using react18 with graphic-walker, try not to use the strict mode, which will lead to drag and drop issues by react-beautiful-dnd.

@ObservedObserver ObservedObserver linked a pull request Apr 10, 2023 that will close this issue
@unidesigner
Copy link
Author

Thanks for the quick response and update! I am looking forward to test the release as it becomes available via npmjs. Can you tell me what you mean with strict mode?

@ObservedObserver
Copy link
Member

It is now available in npmjs: @kanaries/graphic-walker@0.3.1

For example, the entry of your react 18 code might look like

ReactDOM.createRoot(document.getElementById('root') as HTMLElement).render(
  <React.StrictMode>
    <App />
  </React.StrictMode>,
)

You need to remove the <React.StrictMode> for graphic-walker, and it should looks like:

ReactDOM.createRoot(document.getElementById('root') as HTMLElement).render(<App />)

@unidesigner
Copy link
Author

Thanks. This worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants