Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Detect white-dark theme and use appropriate theme #20

Closed
hyiltiz opened this issue Feb 21, 2023 · 4 comments
Closed

[Feat] Detect white-dark theme and use appropriate theme #20

hyiltiz opened this issue Feb 21, 2023 · 4 comments
Assignees
@ObservedObserver
Labels
enhancement New feature or request graphic-walker belong to Graphic Walker project

Comments

@hyiltiz
Copy link

hyiltiz commented Feb 21, 2023

Currently, using pyg.walk(df) on a Jupyter Notebook with a dark theme renders a white widget, where most text are so low contrast that they are effectively invisible.
@ObservedObserver ObservedObserver added enhancement New feature or request graphic-walker belong to Graphic Walker project labels Feb 22, 2023
@ObservedObserver ObservedObserver self-assigned this Feb 23, 2023
@ObservedObserver
Copy link
Member

graphic-walker has supported media themes now. Kanaries/graphic-walker#31

we are upgrading pygwalker to the latest graphic-walker.

gw-dark-scatter

@hyiltiz
Copy link
Author

hyiltiz commented Feb 27, 2023

Does that has any impact on the call site (user API), or it is just an upgrade to the pygwalker's internal calls to graphic-walker?

@Asm-Def
Copy link
Collaborator

Asm-Def commented Feb 28, 2023 •
edited

See pr #48 .

It's just an upgrade of graphic-walker itself, but I'd prefer to export an option for user API in the future.

@ObservedObserver
Copy link
Member

Use pygwalker with auto-theme (based on your device) in the latest version. pip install --upgrade "pygwalker>=0.1.4.6"

@Asm-Def Asm-Def changed the title Detect white-dark theme and use appropriate theme [Feat] Detect white-dark theme and use appropriate theme Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ObservedObserver ObservedObserver

Labels
enhancement New feature or request graphic-walker belong to Graphic Walker project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hyiltiz @Asm-Def @ObservedObserver