New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropping ancient IE versions #1114
Conversation
I'm totally fine to add the EOL dates, but imo while "EOL" may mean "unsupported by the browser vendor" it doesn't mean "unused" or "unsupported by websites". IE 9+ is still heavily used, and I think it's pretty important that they show up on all the tables by default. |
I am not sure what you mean by "heavily used", but available statistics point to the contrary. |
It depends on the site, and the country. Global stats aren't actually useful for determining usage on individual sites. Either way, the primary consumer here isn't imo people looking to see what the latest browser supports, it's people who want to see what "not the latest" browser supports, because that's what's hard to test for themselves. |
IMO we should keep this versions until extended end of support |
Also, 0.77% of 1 billion people (just to pick an arbitrary number of internet users) is 7.7 million humans. That's quite a lot. |
BTW I think we can mark IE 7 as very obsolete. It comes with Windows Vista which end of extended support date is April 11, 2017 |
Yes, I'm comfortable marking IE 7 as very obsolete :-) |
OK, new patch. I am keeping IE7 out, and I am bringing back IE8-IE10 where they make sense. I believe there's no point in having IE9 on the esnext table, for instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we should wait for the bug in the es2016+ table to be fixed before pushing this one.
"test_suites": [ | ||
"es5", | ||
"es6", | ||
"esnext", | ||
"esintl", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IE7 is zeroed on the esintl table, should it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say that the oldest version in a browser line that should be displayed is the newest one that has zero support - so if IE 8 also has zero support and is visible, then it makes sense to hide IE 7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
"obsolete": true, | ||
"test_suites": [ | ||
"es5", | ||
"es6", | ||
"esnext", | ||
"esintl", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IE8 is zeroed on the esintl table, should it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(same logic as above; if IE 9 is zeroed and displayed, then it makes sense to hide IE 8)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, IE9 has half of the items implemented. I'll keep it like this then.
es2016plus/index.html
Outdated
<td class="no obsolete" data-browser="ie9">No</td> | ||
<td class="yes obsolete" data-browser="ie10">Yes</td> | ||
<td class="yes" data-browser="ie11">Yes</td> | ||
<td class="no" data-browser="ie11">No</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is a bug: the data says this is true for ie10, but ie10 is not on this table anymore. But this should not cause the feature to be negated here for ie11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I follow the rule by @ljharb above, I'll have to add IE10 (0 items implemented) since IE11 has one item implemented, which would hide the bug again. This doesn't make much sense since the browsers were obsolete before the standard was in discussion.
I'll also have to add IE9 (0 items implemented) and IE10 (one item implemented) to the es2016+ table, which also don't make much sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that in general it's important to be able to see when support for a thing started landing.
It would also be a fair policy to show the oldest browser that had nonzero support (instead of the newest with zero), as long as we're consistent.
Please see my comments on the review before pushing this one. |
What do you mean by "extended end of support"? IE<11 are not supported by Microsoft in their consumer versions at all, the extended support period has ended as well. Only server/embedded versions are supported on some versions of Windows. |
* IE 10 comes with Windows 7 SP 1 update which is necessary for extended EOL |
Hmm... looks like Windows 7 support is available only with SP 1. I'll update my table |
@chicoxyzzy This is a list of supported Windows versions, not IE versions. Microsoft has dropped support for IE<11 on these systems 1.5 years ago. |
Similarly how Windows 7 is supported only with SP 1, IE on Windows 7 is supported only if updated to v11. I don't really see the difference, anything below is unsupported. |
Ok, I can agree with this, despite the fact that every previous version of Chrome and Firefox (excluding ESR versions) are not supported as well. By the way it's still useful to have them in table considering theirs usage. Actually IE 8 usage is almost equal to Safari 9 + Safari 9.1 usage. Also either IE8 / Safari 9 usage is greater than Edge 15 usage so IE 8 compatibility info is still useful. |
Sure; I agree with what @ljharb said:
So this information may be useful enough to enough many people to still list those versions on the site. |
I think so. I believe all the comments have been addressed, and I added back IE8-IE10 where they make sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's still file a separate issue about that IE 10 bug, because that should be fixed.
LGTM in the meantime.
Thank you, as always! :) |
I filed issue #1118 about the bug. |
Microsoft has EOLed all versions of IE but IE11 more than a year ago:
https://www.microsoft.com/en-us/windowsforbusiness/end-of-ie-support
I am retiring these ancient versions from all tables.