New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ES6 results for IE11 #1312
Conversation
|
@@ -5323,6 +5323,11 @@ exports.tests = [ | |||
typescript1: typescript.corejs, | |||
firefox2: false, | |||
firefox4: true, | |||
ie11: { | |||
val: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather false
. Also, .subarray
test depends on Uint8ClampedArray
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this value supposed to reflect initial release or the version that people are probably using? I believe it is the later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean the note should be added to .subarray too? Wouldn't that be confusing? Maybe the test should be changed to avoid the dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For IE, it’s the latest in that major line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this value supposed to reflect initial release or the version that people are probably using? I believe it is the later.
Just an example: we will set is as true
. babel-preset-env
will load this result. For IE11 on Uint8ClampedArray
preset-env
with useBuiltIns
option will not add a polyfill. But a serious part of users has un-updated versions of IE11.
Do you mean the note should be added to .subarray too?
I don't care, but with current tests it should be false
.
Maybe the test should be changed to avoid the dependency.
IIRC it's already was proposed in another issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current column represents "IE 11 latest". If you want negative results for non-latest IE 11, then you're welcome to add a column.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me? -) Interesting position. The current column is just IE11 with release date 2013-10-17. It's definitely not "IE 11 latest".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preset-env
could override results. Also ideally it should use something what fits better for it than compat-table
, which purpose never was to provide data for preset-env
or anything else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preset-env
could override results.
It's additional special cases. Why?
Also ideally it should use something what fits better for it than
compat-table
Definitely. But currently we haven't any good alternative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a) the release date is for the first version, results always reflect the latest
b) supporting preset-env is ancillary and NOT something that this repo needs to cleave to, especially not when it changes the meaning this project's test columns have had historically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix false positive for early IE11 versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that notes cover all necessary info so I'll approve
@zloirock are you ok with latest changes? |
@chicoxyzzy nope, see my argumentation above - nothing was changed. |
Is everyone ok if we'll show these features as unsupported and will add a note that in latest versions of IE these features was added? |
No, i want them to show as supported if they’re available in the latest version, per precedent. |
This PR has been opened a year ago. Can we get a decision here so that it can be landed in whatever version gets accepted? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I wrote my objections above. I could accept only |
It won't break the web; the columns mean "latest version". Anyone not using the latest version of the thing in the column is already broken if they're relying on this data. |
|
Then it sounds like we should add a new column for the latest IE 11, and mark the current one as very obsolete. |
I agree. But just "obsolete" could be better. |
I don't believe it is productive to add columns for minor versions. How about changing the results to "flagged", keeping the notes on the current PR? |
So we should create issue / PR against |
Everywhere else we indicate latest status. If not, we'd need to mark a bunch of Safari, Chrome and Firefox features as |
^ ftr, that matches my intuition as well as babel-preset-env reality, and is why I think @zloirock's position here is objectively wrong. |
@chicoxyzzy yes, The case from this PR is adding new features, not fixing bugs, so it's a semver minor, not patch. So incorrectly compare it with other browsers, the issue here in a versioning / naming MS browsers. |
The best thing to do is take broken use cases - like “not the latest version of IE 11” and make them more broken, precisely so the users wrongly relying on this nonexistent property have more incentive to stop doing so. It’s unreasonable to insist on maintaining a property that has never existed and does not currently exist. |
I still think that we should merge this. @existentialism @nicolo-ribaudo @JLHwung how hard it would be to handle this change in |
It wouldn't be too hard, we can hard code the old data. |
Typically, overriding a block isn't something I'd ever support; however there's extenuating circumstances here, and we don't want to have to wait a year or more, so if @chicoxyzzy agrees, I'm ok with that. |
After the latest fixes from @Perelandric , it is now possible to run all tests with IE11 (the table layout is still broken, but at least the results are shown). This patch fixes all results that were wrong.