Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Closure Compiler #747

Closed
caridy opened this issue Feb 25, 2016 · 5 comments
Closed

Update Closure Compiler #747

caridy opened this issue Feb 25, 2016 · 5 comments

Comments

@caridy
Copy link

caridy commented Feb 25, 2016

I suspect compat-table is testing closure compiler with the default options without using externs to rewrite the polyfills (which is equivalent to babel-polyfill), that's why you see all the built-ins and built-ins extensions not supported in closure compiler.

@dimvar and @shicks, can you guys help @teppeis to level up the results of closure compiler?

@dimvar
Copy link

dimvar commented Feb 25, 2016

@shicks just added a command-line flag --rewrite_polyfills to use the polyfills. You need to build the compiler from head, it's not in the released compiler yet. See: google/closure-compiler@f2eb08a

@teppeis
Copy link
Contributor

teppeis commented Feb 25, 2016

@dimvar Thanks! I'll update compat-table result after next release.

@caridy
Copy link
Author

caridy commented Mar 28, 2016

🍻

@caridy
Copy link
Author

caridy commented Mar 28, 2016

@dimvar I wonder what's going on with the built-in section from the table. I see WeakMap, WeakSet, Promise, Proxy, Reflect, and most symbols not implemented after using --rewrite_polyfills. I was expecting a little bit better support.

@Dominator008
Copy link

@caridy They are not implemented yet: https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/RewritePolyfills.java#L239-L241. Proxy will probably not be implemented at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants