Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WebKit to r185450 #558

Merged
merged 1 commit into from
Jun 11, 2015
Merged

Update WebKit to r185450 #558

merged 1 commit into from
Jun 11, 2015

Conversation

Constellation
Copy link
Contributor

  • RegExp.prototype.flags is implemented.
  • Update the parser: no escaped reserved words as identifiers.

@Constellation
Update WebKit to r185450
6070278 
+ `RegExp.prototype.flags` is implemented.
+ Update the parser: no escaped reserved words as identifiers.
@ljharb
Copy link
Member

ljharb commented Jun 11, 2015

👍 yay!

@ljharb
Copy link
Member

ljharb commented Jun 11, 2015

This also turns global, multiline, and ignoreCase into accessors, instead of own properties, which is an ES6 change. Perhaps we should add separate RegExp compatibility tests for these?

@kangax
Copy link
Collaborator

kangax commented Jun 11, 2015

Pretty obscure change... You think it's worth it? :)

kangax added a commit that referenced this pull request Jun 11, 2015
@kangax
Merge pull request #558 from Constellation/webkit1
c223ce1 
Update WebKit to r185450
@kangax kangax merged commit c223ce1 into compat-table:gh-pages Jun 11, 2015
@ljharb
Copy link
Member

ljharb commented Jun 11, 2015

@kangax without it, RegExp can't possibly be truly subclassable, so I'd say it's pretty important :-)

@kangax
Copy link
Collaborator

kangax commented Jun 12, 2015

@ljharb ahha, fair enough :) well, let's do it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Constellation @ljharb @kangax