-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome 54 update #881
Chrome 54 update #881
Conversation
@@ -284,6 +284,18 @@ module.exports = { | |||
short: 'CH 52', | |||
note_id: 'experimental-flag', | |||
}, | |||
chrome53: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is Chrome 53 really needed here? There's no other mention to this version in the test results, I don't see the point of the extra column.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any benefits of having Chrome 52-53 as well. More than that someone may need to mention chrome53
in table in any time later. Also it will be stable soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be added then, if necessary, avoiding the cost (size and speed) of adding it earlier "just in case".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like idea of squashing 52 and 53 into one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
We should not be optimizing for column counts in the data itself. If we want columns to be minimized, let's write build/display logic to handle that - the data should always be as granular as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chicoxyzzy, this is not what I have suggested, but simply removing the 53 column while there's no actual need for it. As I understand, you then suggested also removing 52, and I agree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ljharb, I have to disagree. There's no data for Chrome 52 or Chrome 53. You do not create data granularity by creating empty columns of data.
It seems reasonable to remove columns that have identical data, which is not always obvious due to the way the data is defined. But I see no point in knowingly adding empty columns and then process them out because they are empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if I missed the context :-) I agree that empty columns don't serve a purpose, but I'd rather the build process remove empty columns rather than make it harder for someone to add chrome 53-specific data later.
…pertyDescriptors without flags now
BTW estimated release date for Chrome 53 is September 6 and we still don't have it in table |
Chrome 54 supports Object.values, Object.entries and Object.getOwnPropertyDescriptors without flags now