-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
searchPossibleTargets regression #1188
Comments
Hmmm this is something I never thought of. Is there something we can do to keep the short circuit behaviour intact while rectifying this issue? If I get a chance I'll look into it but my life has become ridiculously busy recently so I'm struggling to find time for anything other than work. Without the short circuit, the performance of my app suffers greatly due to the huge number of objects I use. If we could find some sort of workaround that would be great. Perhaps by looking at objects z-index and only short circuiting if it the same as the current active object? Thinking about it... This should be very easy to rectify while keeping the intended performance enhancement. |
Kangax, How can we do this in latest version of Fabric. |
…aving active object shortcut(bug) commented out commented out the section where it tries to shortcut on the active object. This change makes it so that if you select an object, you can NEVER select an object on top of it. Commenting out this section for now. searchPossibleTargets regression fabricjs#1188 fabricjs#1188 older, working: http://jsfiddle.net/fotoguy42/96JNh/1/ newer, busted: http://jsfiddle.net/fotoguy42/R5dpN/1/
+1 regression. This could be toggle by flag but seems mostly application level. |
…aving active object shortcut(bug) commented out commented out the section where it tries to shortcut on the active object. This change makes it so that if you select an object, you can NEVER select an object on top of it. Commenting out this section for now. searchPossibleTargets regression fabricjs#1188 fabricjs#1188 older, working: http://jsfiddle.net/fotoguy42/96JNh/1/ newer, busted: http://jsfiddle.net/fotoguy42/R5dpN/1/
Change 88157a8 in canvas.class.js changed _searchPossibleTargets such that if there are objects on top of the active object, you cannot select them until you deselect the active object. This is not possible if the active object takes up the whole canvas.
in 1.4.0 You can select the object on top http://jsfiddle.net/fotoguy42/96JNh/1/
in 1.4.4 you cannot http://jsfiddle.net/fotoguy42/R5dpN/1/
The text was updated successfully, but these errors were encountered: