Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fabric.Path.clone() and loadFromJSON() with fabric.Path is wrong #330

Closed
Kienz opened this issue Dec 1, 2012 · 4 comments
Closed

fabric.Path.clone() and loadFromJSON() with fabric.Path is wrong #330

Kienz opened this issue Dec 1, 2012 · 4 comments
Labels

Comments

@Kienz
Copy link
Collaborator

Kienz commented Dec 1, 2012

If a fabric.Path object is cloned or the objects were loaded with loadFromJSON() fabric.Path objects left and top properties were wrong.
Left and top properties are set to 0.

Here you can see it:
http://jsfiddle.net/Kienz/73Cta/1/

@kangax
Copy link
Member

kangax commented Dec 1, 2012

Yep, thanks @Kienz, I noticed this as well. We have some of the unit tests failing at the moment because of this. /cc @sjpemberton09

@sjpemberton
Copy link
Contributor

Hey guys.

I've had a look and fixed the problem.
I'll send a pull request now.

Fiddle:
http://jsfiddle.net/3tpkt/1/

@kangax
Copy link
Member

kangax commented Dec 2, 2012

Great! All tests are green now :)

On Sat, Dec 1, 2012 at 10:00 PM, sjpemberton09 notifications@github.comwrote:

Hey guys.

I've had a look and fixed the problem.
I'll send a pull request now.

Fiddle:
http://jsfiddle.net/3tpkt/1/


Reply to this email directly or view it on GitHubhttps://github.com//issues/330#issuecomment-10922056.

@Kienz
Copy link
Collaborator Author

Kienz commented Dec 2, 2012

Thanks a lot. Works great!

@Kienz Kienz closed this as completed Dec 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants