Resubmit: Fix duplication of line styles when inserting a newline in IText #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 12, 2015 12:04
Conflicts: src/mixins/itext_behavior.mixin.js test/unit/itext.js
kangax
added a commit
that referenced
this pull request
May 13, 2015
Resubmit: Fix duplication of line styles when inserting a newline in IText
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmit as requested, merge conflicts resolved
When copying styles from oldStyles[lineIndex] to newStyles[lineIndex + 1] check if previous line was empty (and thus not iterated over) and if true, delete it.
There is a TODO comment in the function but I wasn't sure if that refers to this issue.
//TODO: evaluate if delete old style lines with offset -1
Closes #2188