Clean origins

[asturur]

Cleaning of object origins code.
easier to add functions to switch from topleft, topcenter, bottomright and so on.
Necessary but not sufficietn to fix the pointer of rotated itext that is not top left (#2234)

[asturur]

wait one test missing.

[asturur]

Merged similar code, avoid rotating point if the angle is 0. General code reduction.
I noticed that those functions does not have tests, so we should add some.

[kangax]

These are the only things that look confusing to me. Why -0.5, 0 and 0.5?

[asturur]

because we are always working with half width and half height to translate
the points.

i writing tests for all those functions to be sure they give same result as
old one.
Il 06/giu/2015 05:07, "Juriy Zaytsev" notifications@github.com ha
scritto:

In src/mixins/object_origin.mixin.js
#2257 (comment):

@@ -1,40 +1,55 @@
(function() {

• var degreesToRadians = fabric.util.degreesToRadians;
• var degreesToRadians = fabric.util.degreesToRadians,

•  originXOffset = {
  

•    left: -0.5,
  

These are the only things that look confusing to me. Why -0.5, 0 and 0.5?

—
Reply to this email directly or view it on GitHub
https://github.com/kangax/fabric.js/pull/2257/files#r31863927.

[asturur]

@kangax they give same results in tests but are shorter, also they do not rotate point if there is no angle.

[kangax]

@asturur you mean shorter in code? So you think this is OK to merge?

[asturur]

i think yes.
i separated from test to permit a painless revert.

if you think code looks better and is worth ro skip rotation on angle 0, merge it.

[asturur]

Note: i forgot 1 small optimization ( double calculation of sin and cos ) and to change this.getWidth() with this.getTransformedDimensions().

[coveralls]

Changes Unknown when pulling b22ae4f on asturur:clean-origins into ** on kangax:master**.