Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to word break for textbox #2445

Closed
wants to merge 1 commit into from
Closed

attempt to word break for textbox #2445

wants to merge 1 commit into from

Conversation

asturur
Copy link
Member

@asturur asturur commented Aug 24, 2015

image

It looks working good.
Please test are welcome.

@asturur
Copy link
Member Author

asturur commented Aug 25, 2015

Someone should get an idea about how to handle text like
" Lorem ipsum dolor "
with trailing spaces or consecutive spaces.

@asturur
Copy link
Member Author

asturur commented Aug 25, 2015

@jafferhaider @inssein

@asturur
Copy link
Member Author

asturur commented Aug 25, 2015

/cc: @onassar

@inssein
Copy link
Contributor

inssein commented Aug 25, 2015

@asturur will be checking it out tomorrow, good work :)

@onassar
Copy link

onassar commented Aug 25, 2015

Dang I'm not set up with support for separate classes (eg. textbox.class.js)
Right now, just have everything included in one fabric.js file
Will try and separate things so I can test properly

@asturur
Copy link
Member Author

asturur commented Aug 25, 2015

check how to download and build a branch

@jafferhaider
Copy link
Contributor

@asturur works great!

A few comments:

  1. I'd suggest that breakWords be true by default since that is more inline which how I imagine people will use Textbox ... to limit text within a box.
  2. In other textbox implementations (e.g. the textarea tag in a browser), when you start typing a long word somewhere in the middle of a line, the textbox wraps the long word onto the next line in an attempt to make it fit all in one line. I think the Textbox class should do the same.

@asturur asturur closed this Oct 13, 2015
@asturur asturur deleted the bugfix branch October 13, 2015 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants