Added added/removed events to fabric.Group #4569 #4570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asturur
reviewed
Dec 19, 2017
src/shapes/group.class.js
Outdated
| while (this._objects.length){ | ||
| this.remove(this._objects[0]); | ||
| } | ||
| }, |
There was a problem hiding this comment.
this and the automatic event binding are not part of the PR description.
Also this has a problem:
if you put a group inside a group, when you remove the group from the outside group, this will loose all objects.
|
i'm not sure about this change. |
|
You're right, I'll modify the PR to limit it to _onObjectAdded and _onObjectRemoved, and get rid of the automatic event binding and removing subobjects from the group. I was thinking of the added/removed event as being added/removed from the canvas rather than the object that contained it, which was wrong. It also causes the problem you mentioned above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4569 by adding required code for firing events to _onObjectAdded and _onObjectRemoved