Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added image crop ToSVG support #4738

Merged
merged 8 commits into from Feb 18, 2018
Merged

added image crop ToSVG support #4738

merged 8 commits into from Feb 18, 2018

Conversation

asturur
Copy link
Member

@asturur asturur commented Feb 18, 2018

close #4708

Add a clipPath to image toSVG in order to make crop working

image

image

@asturur
Copy link
Member Author

asturur commented Feb 18, 2018

Needs some test anyway

@asturur asturur merged commit b47815e into master Feb 18, 2018
@asturur asturur mentioned this pull request Feb 18, 2018
@kephin
Copy link

kephin commented Feb 19, 2018

Hi, I saw you referenced the #4736 to #4738. But I don't see the connections between cropping image and scaling it. Do you mind sort of explaining for a little bit, thanks a lot!

@asturur
Copy link
Member Author

asturur commented Feb 19, 2018 via email

@AvaelKross
Copy link
Contributor

@asturur

'" width="', this._element.width || this._element.naturalWidth,
'" height="', this._element.height || this._element.height,

second line doesn't seem to be correct

@asturur
Copy link
Member Author

asturur commented Feb 20, 2018

yep is not.

@kephin
Copy link

kephin commented Feb 23, 2018

@asturur Any update for #4736 ? Or is there anything I can do? Thanks.

@asturur asturur deleted the fix-imag-crop-tosvg branch February 26, 2018 10:05
thiagocunha pushed a commit to thiagocunha/fabric.js that referenced this pull request Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVG output does not respect Image crop attributes
3 participants