Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup kanidm_client bool/return values #472

Closed
QnnOkabayashi opened this issue Jun 11, 2021 · 2 comments · Fixed by #479
Closed

Cleanup kanidm_client bool/return values #472

QnnOkabayashi opened this issue Jun 11, 2021 · 2 comments · Fixed by #479

Comments

@QnnOkabayashi
Copy link
Collaborator

In kanidm_client, there are many functions that return Result<bool, ClientError>, yet the bool is never used on Ok. We should change these to Result<(), ClientError> to decrease confusion. Inspired by @Firstyear's comment:

It represents past williams mistakes. I thought that there would be a case where you could set and it would be Ok() but change nothing (false), but I think we never indicate that so it should be cleaned up. That could be a new issue from this (cleanup kanidm_client bool/return values).
Originally posted by @Firstyear in #465 (comment)
@Firstyear
Copy link
Member

@QnnOkabayashi did you want to do this one? Or do you want me to fix it?

@QnnOkabayashi
Copy link
Collaborator Author

I was gonna fix it Monday

@QnnOkabayashi QnnOkabayashi mentioned this issue Jun 14, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kanidm_client bool/return values
2 participants
@Firstyear @QnnOkabayashi