Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration file & cancel button #78

Closed
TheGhost78 opened this issue Mar 11, 2023 · 6 comments
Closed

Configuration file & cancel button #78

TheGhost78 opened this issue Mar 11, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@TheGhost78
Copy link

YouTube video:
https://www.youtube.com/watch?v=rS0EfA7LoM8

This YouTube video will not download while the attached configuration file is enabled. The download cannot be cancelled - the cancel button has a spinner that just keeps spinning. The only way to cancel it is to close the program.

1080p.txt

@kannagi0303
Copy link
Owner

Hello, I have reviewed this issue.

Normally, when using yt-dlp with a configuration, yt-dlp will give me the video ID (and audio ID) that meets the -f condition. Then, my GUI will use this ID to perform the download. However, in this case, yt-dlp did not give me the ID that meets the -f condition. Before adding the automatic download feature, theoretically, it should not be possible to perform the download operation. However, the automatic download feature allows it to bypass this check.

I will fix the issue by:

  • Allowing the GUI to pre-select a set of IDs if yt-dlp does not provide the information.
  • Stopping the automatic download if there is no ID available.

Thank you.

@kannagi0303 kannagi0303 added the bug Something isn't working label Mar 13, 2023
@kannagi0303
Copy link
Owner

Hello,

I have made improvements to this part in the new version to avoid this issue. However, the new version has undergone significant changes and may have some rough edges. If you're interested, you can try out the new version and see how it works.

@TheGhost78
Copy link
Author

Unfortunately, I can't get past the 'Analyze' stage - and that is with or without any configuration file.

@kannagi0303
Copy link
Owner

A user previously mentioned a similar issue. Would you like to try updating yt-dlp and see if it resolves the problem?

@TheGhost78
Copy link
Author

Thanks - working now. I especially like the chapter embed!

@TheGhost78
Copy link
Author

I got the error that you can see in the attachments. You can click 'Continue' and it'll work - but this is the first time I've een this type of error.

Microsoft  NET Error
Microsoft .NET Error Details.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants