Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOP_IRE entries not generated for processes defined as IRE in ~FI_Process table #28

Closed
olejandro opened this issue Jan 12, 2024 · 9 comments

Comments

@olejandro
Copy link

It seems that TOP_IRE entries are not generated for processes if they are defined as IRE in an ~FI_Process table. The absence of the relevant entries leads to the processes not being recognised as trade processes by TIMES.

At the same time, PRC_MAP does include the relevant entries.

@olejandro olejandro changed the title TOP_IRE entries not generated for processes defined as IRE in ~FI_Process able TOP_IRE entries not generated for processes defined as IRE in ~FI_Process table Jan 12, 2024
@Antti-L
Copy link

Antti-L commented Jan 12, 2024

Some background info: Olex was not able to make a UC constraint based on UC_IRE working, and approached me for an explanation. I found out that the process referred to in UC_IRE was not a trade process (even though it was defined to be of type IRE), which explained the problem.

I think that VEDA should either recognize IRE as a way of defining the process as a trade process (I guess it should be like IMP+EXP), or reject it and issue an error. Letting it just through without actually making the process as a trade process is a source of inconsistency and may potentially cause notable confusion. I am now adding a TIMES QA_Check for it as well, but I think it would be good to catch under VEDA.

@akanudia
Copy link
Contributor

@Antti-L, we can add TOP_IRE entries if we assume IMPEXP as the exogenous region. Would that be OK?

@Antti-L
Copy link

Antti-L commented Jan 29, 2024

Yes, sure that would be ok, just like with IMP+EXP. Then this TIMES process type would be more completely supported by VEDA (the IMP and EXP types are not even known by TIMES).

@akanudia
Copy link
Contributor

Done; will be available in the next update.

@akanudia
Copy link
Contributor

akanudia commented Feb 6, 2024

available in version 3.0.4

@akanudia akanudia closed this as completed Feb 6, 2024
@Antti-L
Copy link

Antti-L commented Feb 6, 2024

available in version 3.0.4

Was that premature? I see Revert "3.0.4.0 released" in the Localhost folder, and the package available there is v3.0.2, i.e. even v3.0.3 seems to have disappeared. 😿

@olejandro
Copy link
Author

Seems that both have been reverted: https://github.com/kanors-emr/Veda2.0-Installation/commits/master/

@akanudia
Copy link
Contributor

akanudia commented Feb 7, 2024

Sincere apologies for the confusion. The FI_T tag QC enhancement had forced us to change some core data processing that needed more thorough testing than we did before releasing version 3.0.3. We should be able to release 3.0.5 later today, but it could also take another day.

At this time, 3.0.2 is the last stable version.

@akanudia akanudia reopened this Feb 7, 2024
@akanudia
Copy link
Contributor

akanudia commented Feb 7, 2024

Version 3.0.5 has been released.

@akanudia akanudia closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants